Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnecessary request when saving a user #8013

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Nov 22, 2022

Description

We've fixed a bug where changing the role of a user without changing any other data would cause an unnecessary request.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Nov 22, 2022
@JammingBen JammingBen force-pushed the fix-unnecessary-user-save-request branch from 5008c5c to 38d7d18 Compare November 22, 2022 14:25
@sonarcloud
Copy link

sonarcloud bot commented Nov 22, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label Nov 22, 2022
@kulmann kulmann merged commit 1fef115 into stable-6.0 Nov 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-unnecessary-user-save-request branch November 23, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants