Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Enhancement: Increase SearchBar height #8056

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Dec 1, 2022

Description

We increased the searchbar height to fit the design better.
When comparing with other web services our search input

Screenshots (if appropriate):

Before:
search2

After:
search

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@lookacat lookacat force-pushed the enhancement-increase-searchbar-height branch from 92c893c to 8c221af Compare December 1, 2022 13:46
@ownclouders
Copy link
Contributor

ownclouders commented Dec 1, 2022

Results for oC10SharingIntGroups https://drone.owncloud.com/owncloud/web/30293/25/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalGroups-shareWithGroups_feature-L222.png

webUISharingInternalGroups-shareWithGroups_feature-L222.png

@lookacat lookacat changed the title Enhancement: Increase SearchBar height [full-ci] Enhancement: Increase SearchBar height Dec 1, 2022
@lookacat lookacat marked this pull request as ready for review December 1, 2022 14:16
@lookacat lookacat force-pushed the enhancement-increase-searchbar-height branch from 8c221af to f19c2a3 Compare December 1, 2022 14:17
@kulmann kulmann force-pushed the enhancement-increase-searchbar-height branch from f19c2a3 to 764c2be Compare December 2, 2022 15:13
@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann kulmann merged commit fe341e5 into master Dec 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the enhancement-increase-searchbar-height branch December 5, 2022 08:15
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants