Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Remove navigation text flickering #8080

Merged
merged 3 commits into from
Dec 8, 2022
Merged

Bugfix: Remove navigation text flickering #8080

merged 3 commits into from
Dec 8, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Dec 8, 2022 •
edited
Loading

Description

When you use the left sidebar in light mode the text flickers on transition.
We've fixed a bug that caused the navigation text to flicker in light mode.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@lookacat lookacat marked this pull request as ready for review December 8, 2022 10:57
@lookacat lookacat force-pushed the bugfix-navigation-text-flickering branch from 1a97f69 to 19a47ae Compare December 8, 2022 11:20
@lookacat lookacat requested a review from kulmann December 8, 2022 11:21
@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann
Copy link
Member

kulmann commented Dec 8, 2022

nice attention to detail 👍 had to look a couple of times to see the difference, but once you see it it was really irritating.

@lookacat lookacat merged commit bcc9f21 into stable-6.0 Dec 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the bugfix-navigation-text-flickering branch December 8, 2022 13:16
ownclouders pushed a commit that referenced this pull request Dec 8, 2022
@lookacat
commit bcc9f21
51cbd80 
Author: Paul Neubauer <paulneubauer@live.de>
Date:   Thu Dec 8 14:16:54 2022 +0100

    Bugfix: Remove navigation text flickering (#8080)

    * Bugfix: Remove navigation text flickering

    * Update changelog

    * Update changelog
ownclouders pushed a commit that referenced this pull request Dec 9, 2022
@lookacat
commit bcc9f21
0ec58d7 
Author: Paul Neubauer <paulneubauer@live.de>
Date:   Thu Dec 8 14:16:54 2022 +0100

    Bugfix: Remove navigation text flickering (#8080)

    * Bugfix: Remove navigation text flickering

    * Update changelog

    * Update changelog
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lookacat @kulmann @AlexAndBear