Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disappearing space members when adding links #8082

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Fix disappearing space members when adding links #8082

merged 2 commits into from
Dec 12, 2022

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Dec 8, 2022 •
edited
Loading

Description

We've fixed a bug where adding links to a space would remove newly added members in the UI.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Dec 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 💪

@kulmann kulmann merged commit 4d52c74 into stable-6.0 Dec 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-disappearing-space-members branch December 12, 2022 13:50
ownclouders pushed a commit that referenced this pull request Dec 12, 2022
@JammingBen
commit 4d52c74
f418a15 
Author: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
Date:   Mon Dec 12 14:50:34 2022 +0100

    Fix disappearing space members when adding links (#8082)
@JammingBen JammingBen mentioned this pull request Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

@lookacat lookacat Awaiting requested review from lookacat

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @kulmann @AlexAndBear