Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vite regressions #8099

Merged
merged 2 commits into from
Dec 10, 2022
Merged

Fix Vite regressions #8099

merged 2 commits into from
Dec 10, 2022

Conversation

dschmidt
Copy link
Member

@dschmidt dschmidt commented Dec 9, 2022 •
edited
Loading

Description

config.json should not be copied to dist/ in production builds.

I reenabled rollup-plugin-gzip after taking a quick look at vite-plugin-compress and vite-plugin-compression: one supports only brotli (and no standard gzip) and both don't seem to be as well maintained as rollup-plugin-gzip and I could not see any benefit over our former solution, so I decided to go back to what we used anyway.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Dec 9, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dschmidt
Copy link
Member Author

dschmidt commented Dec 9, 2022

Apparently not all html assets are gzipped, blocker or should we look at that in a follow up?

@kulmann kulmann merged commit 4f058fe into master Dec 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the vite-improvements branch December 10, 2022 05:19
@kulmann
Copy link
Contributor

kulmann commented Dec 10, 2022

Apparently not all html assets are gzipped, blocker or should we look at that in a follow up?

I did the "answering by merging". 😁 seriously, not shipping the config.json is by far more important than two html files not being compressed. Fine as a followup. 🙂

ownclouders pushed a commit that referenced this pull request Dec 10, 2022
@kulmann
commit 4f058fe
286e456 
Merge: c9158b7 874a2bf
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Sat Dec 10 06:19:37 2022 +0100

    Merge pull request #8099 from owncloud/vite-improvements
ownclouders pushed a commit that referenced this pull request Dec 12, 2022
@kulmann
commit 4f058fe
e054481 
Merge: c9158b7 874a2bf
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Sat Dec 10 06:19:37 2022 +0100

    Merge pull request #8099 from owncloud/vite-improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dschmidt @kulmann