Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support browsers that are 1 year old #8135

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Dec 19, 2022

Description

This PR tackles two things:

  • we want to support more than the last 2 versions, because last 2 versions frequently let's e.g. firefox extended support releases (esr) run into the unsupported browser situation. Chrome is probably similar. We expect users to be on a recent-is browser, but last 2 versions is too harsh.
  • our vite config was actually ignoring the browserslist config, as it only uses esbuild targets. Which is a different thing. Added a plugin to transform browserslist into esbuild targets. If we don't want to do that we need to move away from browserslist.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

cc @mmattel as this is relevant for the docs.

@update-docs
Copy link

update-docs bot commented Dec 19, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarcloud
Copy link

sonarcloud bot commented Dec 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell C 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mmattel
Copy link
Contributor

mmattel commented Dec 20, 2022

relevant for the docs

Can you tell how docs can support?

@kulmann kulmann self-assigned this Dec 21, 2022
@kulmann
Copy link
Member Author

kulmann commented Dec 21, 2022

relevant for the docs

Can you tell how docs can support?

If I remember correctly you have a list of supported browsers somewhere in the docs. This PR changes supported versions (but only for web master, not for the stable GA stream).

@mmattel
Copy link
Contributor

mmattel commented Dec 21, 2022

For the reference, this is located at: https://doc.owncloud.com/webui/next/owncloud_web/requirements.html#desktop-requirements

Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I had already approved this

@kulmann
Copy link
Member Author

kulmann commented Dec 21, 2022

For the reference, this is located at: https://doc.owncloud.com/webui/next/owncloud_web/requirements.html#desktop-requirements

Thanks. I'll hit the merge button now, since the PR is approved. Now it's not clear to me what should happen to the docs page. It shows Latest 2 versions for Chrome, Firefox and Edge. But with this PR the web master supports all versions from 1 year ago until now for those browsers. For the stable product we stay at Latest 2 versions.

@kulmann kulmann merged commit ca30726 into master Dec 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the support-older-browsers branch December 21, 2022 11:52
@mmattel
Copy link
Contributor

mmattel commented Dec 21, 2022

Q: I just don't know it, does web show somewhere its version on the screen?

@kulmann
Copy link
Member Author

kulmann commented Dec 21, 2022

Q: I just don't know it, does web show somewhere its version on the screen?

Yes, in the browser console. But unfortunately at the moment both web stable-6.0 and master show 6.0.0 (because that was the latest release). master will switch to 7.0.0 whenever we do the next official release from master.

@mmattel
Copy link
Contributor

mmattel commented Dec 21, 2022

ok, there is atm no "user-friedly" version accessible. I have to think about how to solve this.

Note that it shoud be considered making this info available to ordinary users - exact for such cases where we have to reference in the documentation to stuff that has changed and is mentionable. To be considered that we bundle with ocis and have an app for oc10...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants