[full-ci] Space group members #8161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
introduce isMember check to detect if a user is a direct or indirect member of a space
fschade
force-pushed
the
spaces-add-invite-group
branch
from
2695e80
to
37e77eb
Compare
fschade
changed the title
|
Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/31076/66/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L54.pngwebUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L55.pngwebUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L56.pngwebUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L57.pngwebUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L58.pngwebUISharingFolderPermissionsGroups-sharePermissionsGroup_feature-L59.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L100.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L101.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L102.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L103.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L122.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L123.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L126.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L156.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L157.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L158.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L161.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L170.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L21.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L36.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L52.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L68.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L99.png |
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/31108/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31108/tracing/upload-resources-in-personal-space-alice-2023-1-3-10-26-22.zip |
fix FileShares snapshots fix failing FileShares acceptance tests
fschade
force-pushed
the
spaces-add-invite-group
branch
from
3813cf8
to
a705861
Compare
fschade
requested review from
JammingBen,
dschmidt and
kulmann
and removed request for
JammingBen and
dschmidt
|
should we create an e2e user story for that or integrate it in a existing story? |
That would be nice, can you talk to @lookacat , he planned to create one today. But please as separate pr, we need to get this merged today. thank you 😘 |
JammingBen
requested changes
Jan 3, 2023
...es/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/tests/unit/components/SideBar/Shares/SpaceMembers.spec.ts
Outdated
Show resolved
Hide resolved
|
Also, loading my personal space gives me console errors: Does it work for you @fschade ? |
It needs the latest master ocis, which version is in use? |
|
@fschade Ahhh sorry, now it works 🙈 Thanks! I found another nitpick though:
|
fixed in 53e94f8 |
|
SonarCloud Quality Gate failed. |
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr allows to select groups int the space member sharing dialogue.
So far it was only possible to select users.
Related Issue
Motivation and Context
be able to share resources to groups instead of user only.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: