[full-ci] Vue 3: Use vue3-gettext
#8257
Conversation
JammingBen
force-pushed
the
use-vue3-gettext
branch
2 times, most recently
from
19e2c76
to
323475d
Compare
|
Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/31766/13/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIWebdavLockProtection-delete_feature-L33.pngwebUIWebdavLockProtection-delete_feature-L34.png |
JammingBen
force-pushed
the
use-vue3-gettext
branch
from
323475d
to
0b2ef85
Compare
dschmidt
force-pushed
the
use-vue3-gettext
branch
from
0b2ef85
to
a97d466
Compare
| import translations from '../l10n/translations.json' | ||
|
|
||
| const config = { | ||
| language: 'en', // TODO BEFORE MERGE: Access current locale |
There was a problem hiding this comment.
I like that we removed this TODO BEFORE MERGE from master 😂
JammingBen
force-pushed
the
use-vue3-gettext
branch
from
a97d466
to
63629b3
Compare
JammingBen
force-pushed
the
use-vue3-gettext
branch
from
79c31cd
to
17550ac
Compare
JammingBen
force-pushed
the
use-vue3-gettext
branch
from
e8252f5
to
656628e
Compare
| @@ -24,6 +24,9 @@ describe('OcStatusIndicators', () => { | |||
| resource: fileResource, | |||
| indicators: [indicator], | |||
| target: 'test' | |||
| }, | |||
| global: { | |||
| plugins: [...defaultPlugins()] | |||
There was a problem hiding this comment.
why spreading? unnecessary [Symbol.iterator]call.
defaultPlugins()
There was a problem hiding this comment.
Basically all tests have it this way, just because it is easier to add more plugins. We think the overhead can be neglect in the test suite.
| @@ -35,6 +38,9 @@ describe('OcStatusIndicators', () => { | |||
| resource: fileResource, | |||
| indicators: [indicator], | |||
| target: 'test' | |||
| }, | |||
| global: { | |||
| plugins: [...defaultPlugins()] | |||
| @@ -128,6 +128,7 @@ describe('OcTable.sort', () => { | |||
| data | |||
| }, | |||
| global: { | |||
| plugins: [...defaultPlugins()], | |||
| @@ -175,6 +176,7 @@ describe('OcTable.sort', () => { | |||
| sortDir: sortDirOld | |||
| }, | |||
| global: { | |||
| plugins: [...defaultPlugins()], | |||
| store: Store<any> | ||
| }): Promise<void> => { | ||
| }): Promise<any> => { | ||
| const store = new Store({ ...storeOptions }) |
There was a problem hiding this comment.
if storeOptions are deep i would prefer to use Object.assign (shallow clone)
There was a problem hiding this comment.
... is shallow as well AFAIK. We just moved this part basically, it was like this before as well.
| createGettext({ | ||
| defaultLanguage: navigator.language.substring(0, 2), | ||
| silent: true, | ||
| ...options |
There was a problem hiding this comment.
can you put the options spreading upfront? My personal taste :)
There was a problem hiding this comment.
In this case we want options to possibly overwrite the defaults, so we need it in this order. The other cases above are valid though, I adjusted it 👍
|
Kudos, SonarCloud Quality Gate passed! |
Description
Use
vue3-gettextand get rid of the old version.We also removed the store from the
defaults.jsfile as we now handle this inannounceStore(). This was not necessary for this PR, but since we touched that code anyways we thought it would be nicer.#7948
Types of changes