Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Extended download folders for kinder garden feature #8264

Merged
merged 4 commits into from
Jan 30, 2023

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Jan 18, 2023

Description

This PR refactors the download function to be able to download folders as well since previously the download function only downloads the files. This is done in order to extend the download folder feature to kindergarten.featurefor oCIS and oc10.

Related Issue

#8101

@SagarGi SagarGi self-assigned this Jan 18, 2023
@SagarGi SagarGi mentioned this pull request Jan 18, 2023
18 tasks
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others look good

@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 1825e91 into stable-6.0 Jan 30, 2023
@delete-merged-branch delete-merged-branch bot deleted the expand_kinder_gardern branch January 30, 2023 11:51
ownclouders pushed a commit that referenced this pull request Jan 31, 2023
Merge: 9cbbe7f 4e81e5c
Author: Phil Davis <phil@jankaritech.com>
Date:   Mon Jan 30 17:36:23 2023 +0545

    Merge pull request #8264 from owncloud/expand_kinder_gardern

    [tests-only][full-ci]Extended download folders for kinder garden feature
@SagarGi
Copy link
Member Author

SagarGi commented Jan 31, 2023

TODO:

ownclouders pushed a commit that referenced this pull request Feb 1, 2023
Merge: 9cbbe7f 4e81e5c
Author: Phil Davis <phil@jankaritech.com>
Date:   Mon Jan 30 17:36:23 2023 +0545

    Merge pull request #8264 from owncloud/expand_kinder_gardern

    [tests-only][full-ci]Extended download folders for kinder garden feature
ownclouders pushed a commit that referenced this pull request Feb 2, 2023
Merge: 9cbbe7f 4e81e5c
Author: Phil Davis <phil@jankaritech.com>
Date:   Mon Jan 30 17:36:23 2023 +0545

    Merge pull request #8264 from owncloud/expand_kinder_gardern

    [tests-only][full-ci]Extended download folders for kinder garden feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants