-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Extended download folders for kinder garden feature #8264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/31854/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31854/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2023-1-19-05-27-28.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31854/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2023-1-19-05-27-55.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31854/tracing/file-alice-2023-1-19-05-32-54.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31854/tracing/file-brian-2023-1-19-05-33-00.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31854/tracing/public-link-alice-2023-1-19-05-29-54.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/31854/tracing/public-link-anonymous-2023-1-19-05-30-14.zip |
SagarGi
force-pushed
the
expand_kinder_gardern
branch
from
January 19, 2023 06:07
a2a52d3
to
ad39df7
Compare
SagarGi
requested review from
SwikritiT,
saw-jan,
amrita-shrestha and
ScharfViktor
January 19, 2023 06:33
phil-davis
reviewed
Jan 19, 2023
saw-jan
reviewed
Jan 20, 2023
SagarGi
force-pushed
the
expand_kinder_gardern
branch
from
January 23, 2023 09:14
16392fa
to
d4ac744
Compare
saw-jan
reviewed
Jan 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
others look good
SwikritiT
reviewed
Jan 27, 2023
SagarGi
force-pushed
the
expand_kinder_gardern
branch
from
January 30, 2023 09:02
d4ac744
to
4e81e5c
Compare
Kudos, SonarCloud Quality Gate passed! |
ScharfViktor
approved these changes
Jan 30, 2023
phil-davis
approved these changes
Jan 30, 2023
TODO:
|
ownclouders
pushed a commit
that referenced
this pull request
Feb 1, 2023
ownclouders
pushed a commit
that referenced
this pull request
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the download function to be able to download folders as well since previously the download function only downloads the files. This is done in order to extend the download folder feature to
kindergarten.feature
foroCIS
andoc10
.Related Issue
#8101