Fix sidebar data loading for users #8276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the loading of additional user data which is needed in the sidebar.
Before, this was handled by a custom
showPanel
event, that first loaded the additional data, then opened the sidebar. Problems here:The new approach uses the
eventBus
which is coupled with theuseSidebar
composable. Opening/closing the sidebar and setting the active panels is all being handled by the composable. Furthermore, the additional data is being loaded when a user gets selected. This way, it works on select-toggle as well.Also, the sidebar now uses the loading state properly to show a loading spinner during data loading.
Related Issue
Types of changes