Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expiration for space members and apply new permission structure #8320

Merged
merged 11 commits into from
Jan 31, 2023
Merged

Add expiration for space members and apply new permission structure #8320

merged 11 commits into from
Jan 31, 2023

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Jan 26, 2023 •
edited
Loading

Description

We've added expiration for space members and made Web compatible with the new permission structure that was introduced by owncloud/ocis#5453.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

To-Dos:

  • e2e tests

@JammingBen JammingBen mentioned this pull request Jan 26, 2023
Merged
@C0rby C0rby mentioned this pull request Jan 26, 2023
Merged
@owncloud owncloud deleted a comment from update-docs bot Jan 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

57.1% 57.1% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen marked this pull request as ready for review January 30, 2023 15:16
kulmann
kulmann approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can we merge this right away? Doesn't break anything and when the ocis PR gets merged it will supposedly "just work"... so bumping web in ocis asap makes sense...

@JammingBen JammingBen merged commit 0098580 into master Jan 31, 2023
@delete-merged-branch delete-merged-branch bot deleted the space-member-permissions branch January 31, 2023 15:48
This was referenced Jan 31, 2023
Closed
Merged
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby left review comments

@kulmann kulmann kulmann approved these changes

Assignees

@C0rby C0rby

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @kulmann @C0rby