-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: slightly faster key up/down #8356
Conversation
911a196
to
09f2d13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found an edge case:
- Select files via "shift" + "arrow down" until you reach the end of the files list.
- Now try to navigate up again without shift -> will work one time, then it's broken.
packages/web-app-files/tests/unit/components/FilesList/KeyboardActions.spec.ts
Outdated
Show resolved
Hide resolved
02d31a3
to
ccd657c
Compare
thank you! Found the issue... it lies in weird updating conditions of the |
…dActions.spec.ts Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
ccd657c
to
e7c03a1
Compare
Kudos, SonarCloud Quality Gate passed! |
Description
Keyboard interaction with file listings needs a major rework (should be a composable instead of a component + is not compatible with the tiles view), so I didn't dig deeper. This PR is just a slight improvement of the render performance of the current implementation of up/down key uses, since it was a low hanging fruit.
Types of changes
Checklist: