Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: slightly faster key up/down #8356

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Feb 2, 2023

Description

Keyboard interaction with file listings needs a major rework (should be a composable instead of a component + is not compatible with the tiles view), so I didn't dig deeper. This PR is just a slight improvement of the render performance of the current implementation of up/down key uses, since it was a low hanging fruit.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found an edge case:

  1. Select files via "shift" + "arrow down" until you reach the end of the files list.
  2. Now try to navigate up again without shift -> will work one time, then it's broken.

@kulmann
Copy link
Member Author

kulmann commented Feb 15, 2023

I found an edge case:

  1. Select files via "shift" + "arrow down" until you reach the end of the files list.
  2. Now try to navigate up again without shift -> will work one time, then it's broken.

thank you! Found the issue... it lies in weird updating conditions of the latestSelectedId. IMO that prop doesn't belong in the vuex store at all... but no time to look into refactoring that at the moment.

kulmann and others added 3 commits February 15, 2023 17:21
…dActions.spec.ts

Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.4% 82.4% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit ac2475e into master Feb 16, 2023
@delete-merged-branch delete-merged-branch bot deleted the key-up-down-performance branch February 16, 2023 08:16
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants