-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup sidebar actions (fileinfo + spaces) #8398
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
packages/web-app-files/src/components/SideBar/Actions/SpaceActions.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! 😍 A few annotations, mainly to your code-comments.
packages/web-app-files/src/components/SideBar/Actions/SpaceActions.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/SideBar/Actions/SpaceActions.vue
Outdated
Show resolved
Hide resolved
Not sure why the build is failing. What needs to be done? |
The snapshot tests are failing. A snapshot includes the DOM-structure of a component. When you change the DOM (by adding classes e.g.), these snapshots need to be updated as well, otherwise those tests fail. You can update all snapshots by running |
34a487e
to
9d83a80
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Description
Make list of available sidebar actions (File info + Spaces) look better:
Before:
After:
Related Issue
Types of changes
Checklist:
Open tasks: