Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup sidebar actions (fileinfo + spaces) #8398

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Conversation

hurradieweltgehtunter
Copy link
Contributor

@hurradieweltgehtunter hurradieweltgehtunter commented Feb 8, 2023

Description

Make list of available sidebar actions (File info + Spaces) look better:

  • add slight border below file/space name to sepaate it from actions
  • add standardized spacing between elements to make it look like other actions lists (e.g. context menu in file list)
  • add hover effect
  • expand button to make full width clickable

Before:
grafik

After:
grafik

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

Open tasks:

@update-docs
Copy link

update-docs bot commented Feb 8, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! 😍 A few annotations, mainly to your code-comments.

@hurradieweltgehtunter
Copy link
Contributor Author

Not sure why the build is failing. What needs to be done?

@JammingBen
Copy link
Collaborator

Not sure why the build is failing. What needs to be done?

The snapshot tests are failing. A snapshot includes the DOM-structure of a component. When you change the DOM (by adding classes e.g.), these snapshots need to be updated as well, otherwise those tests fail.

You can update all snapshots by running pnpm test:unit -u.

AlexAndBear
AlexAndBear previously approved these changes Feb 8, 2023
@AlexAndBear AlexAndBear self-requested a review February 8, 2023 14:00
@AlexAndBear AlexAndBear dismissed their stale review February 8, 2023 14:01

whait for bkulman

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@kulmann kulmann merged commit 7d05f12 into master Feb 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the sidebar-actions-beautify branch February 10, 2023 13:14
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Nonfunctional Will not change behavior Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Right Sidebar] Fix layout of action lists
5 participants