-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Init trash overview #8515
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
092c208
to
e1109d2
Compare
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/33222/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33222/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2023-3-1-03-37-38.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33222/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2023-3-1-03-38-07.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33222/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-carol-2023-3-1-03-38-13.zip |
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/33385/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/33385/tracing/user-login-can-be-managed-in-the-admin-settings-admin-2023-3-7-12-25-08.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the padding on the left side between the sidebar and the icon is a bit small on the first glance but just my opinion otherwise fine 👍🏼
Few annotations from my side, some things may be for a follow-up:
Out of curiosity: Why did you remove the "Navigate to space" breadcrumb action? I found that quite useful actually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 💪 🗑️
Kudos, SonarCloud Quality Gate passed! |
Force merging. An unrelated e2e test failed in the login step due to a timeout. |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: