Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e-test] Do not share versions. added test where share receiver does not see file version #8779

Merged
merged 5 commits into from
Apr 11, 2023

Conversation

ScharfViktor
Copy link
Contributor

related owncloud/ocis#5531
Until PR 5531 is in the master -> webCI still red

  • share receiver does not see file version
  • viewer-member of the project space does not see file version
  • editor-member of the project space see file version

@update-docs
Copy link

update-docs bot commented Apr 5, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor force-pushed the doNotShareVersionChangeE2eTest branch 2 times, most recently from d0bf3b3 to 5143e26 Compare April 5, 2023 12:55
@ScharfViktor ScharfViktor force-pushed the doNotShareVersionChangeE2eTest branch from 5143e26 to 05206d4 Compare April 5, 2023 20:38
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan
Copy link
Member

saw-jan commented Apr 11, 2023

> identifier@1.0.0 build /go/src/github.com/owncloud/ocis/services/idp
> node --openssl-legacy-provider scripts/build.js && rm -f build/service-worker.js

node: bad option: --openssl-legacy-provider
 ELIFECYCLE  Command failed with exit code 9.
make[1]: *** [Makefile:57: pnpm-build] Error 1
make: *** [Makefile:177: ci-node-generate] Error 1
Retries exhausted

Need node v18 to build (generate nodejs) ocis. Like in PR #8774

@ScharfViktor
Copy link
Contributor Author

Need node v18 to build (generate nodejs) ocis. Like in PR #8774

done. thanks

@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ScharfViktor ScharfViktor merged commit b98a538 into master Apr 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the doNotShareVersionChangeE2eTest branch April 11, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants