-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init custom translations #8790
Merged
Merged
Init custom translations #8790
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
95dad67
Init
97b88dc
rm unused import
2493044
don't throw
bd195f6
add changelog item
255d92e
add changelog item
2fb5a94
Continue
6347365
Docs
91ca4f7
enhancements
4ad3991
Add new helper
0f794ea
Re-order
f796f20
Enhacement
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
Enhancement: Custom translations | ||
|
||
We have added the possibility to include own translations to override existing translations. | ||
To inject custom translations add the following property to your `config.json`, `"customTranslation": [{ "url": "https://localhost:9200/translations.json" }]`. | ||
|
||
https://github.com/owncloud/web/pull/8790 | ||
https://github.com/owncloud/web/issues/8791 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import { ConfigurationManager } from 'web-pkg' | ||
import { v4 as uuidV4 } from 'uuid' | ||
import merge from 'lodash-es/merge' | ||
|
||
export const loadCustomTranslations = async ({ | ||
configurationManager | ||
}: { | ||
configurationManager: ConfigurationManager | ||
}): Promise<unknown> => { | ||
const customTranslations = {} | ||
for (const customTranslation of configurationManager.customTranslations) { | ||
const customTranslationResponse = await fetch(customTranslation.url, { | ||
headers: { 'X-Request-ID': uuidV4() } | ||
}) | ||
if (customTranslationResponse.status !== 200) { | ||
console.error( | ||
`translation file ${customTranslation} could not be loaded. HTTP status-code ${customTranslationResponse.status}` | ||
) | ||
continue | ||
} | ||
try { | ||
const customTranslationJSON = await customTranslationResponse.json() | ||
merge(customTranslations, customTranslationJSON) | ||
} catch (e) { | ||
console.error(`translation file ${customTranslation} could not be parsed. ${e}`) | ||
} | ||
} | ||
return customTranslations | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nitpick: tiny performance improvement possible by splitting this into promise creation and awaiting the resolved promise together with other promises. This is a good thing because the promise execution starts immediately with creation, so this enables parallel processing instead of awaiting promises sequentially.
In other words:
Please split this line into:
for promise creation and add that to the
Promise.all
. You can access the resolved custom translations like this: