Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Public link change password validation bugfix #8864

Merged
merged 2 commits into from
Apr 20, 2023
Merged

[full-ci] Public link change password validation bugfix #8864

merged 2 commits into from
Apr 20, 2023

Conversation

lookacat
Copy link
Contributor

Description

We've fixed a bug that caused the error message for the public link password to stay forever.
For more info see: #8521

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@lookacat lookacat force-pushed the public-link-change-password-validation-bugfix branch from c6c2e43 to 0bc62b0 Compare April 19, 2023 12:26
@lookacat lookacat marked this pull request as ready for review April 19, 2023 12:27
@lookacat lookacat changed the title Public link change password validation bugfix [full-ci] Public link change password validation bugfix Apr 20, 2023
@lookacat lookacat force-pushed the public-link-change-password-validation-bugfix branch from f023564 to 2b41105 Compare April 20, 2023 08:33
@lookacat lookacat force-pushed the public-link-change-password-validation-bugfix branch from 01129c8 to 4094dc4 Compare April 20, 2023 09:26
@AlexAndBear
Copy link
Contributor

Checked again, the default case is still -> click edit password, confirm button enabled

AlexAndBear
AlexAndBear requested changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not how we like it

image

@lookacat
Copy link
Contributor Author

cant reproduce it :/

@lookacat lookacat force-pushed the public-link-change-password-validation-bugfix branch from 4094dc4 to 91cae9d Compare April 20, 2023 09:38
@AlexAndBear
Copy link
Contributor

NVM vite crashed

@AlexAndBear
Copy link
Contributor

Please request me again if this is solved =D

@lookacat lookacat force-pushed the public-link-change-password-validation-bugfix branch from 91cae9d to d6e5b10 Compare April 20, 2023 09:52
AlexAndBear
AlexAndBear approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@lookacat lookacat merged commit b7c9f96 into master Apr 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the public-link-change-password-validation-bugfix branch April 20, 2023 12:08
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Password field can't be empty message
3 participants
@lookacat @AlexAndBear @JammingBen