Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display remaining link time #8866

Merged
merged 9 commits into from
Apr 20, 2023
Merged

Display remaining link time #8866

merged 9 commits into from
Apr 20, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Apr 19, 2023 •
edited
Loading

Description

For more details see: #8211

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@lookacat lookacat force-pushed the display-remaining-link-time branch from f7f7fd3 to c733fe4 Compare April 19, 2023 12:59
@lookacat lookacat marked this pull request as ready for review April 19, 2023 12:59
JammingBen
JammingBen requested changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebasing your PR with current master should fix the failing unit tests.

packages/web-app-files/src/components/SideBar/Shares/Links/DetailsAndEdit.vue Outdated Show resolved Hide resolved
@lookacat lookacat force-pushed the display-remaining-link-time branch from 6154ee2 to 4a85186 Compare April 20, 2023 08:10
@AlexAndBear
Copy link
Contributor

AlexAndBear commented Apr 20, 2023 •
edited
Loading

image

Create a link will show this (as it has no expiry date)

@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@lookacat lookacat merged commit c8ecdaf into master Apr 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the display-remaining-link-time branch April 20, 2023 12:13
@kulmann kulmann mentioned this pull request May 2, 2023
Merged
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@hurradieweltgehtunter hurradieweltgehtunter Awaiting requested review from hurradieweltgehtunter

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display remaining time on link shares with expiration date
4 participants
@lookacat @AlexAndBear @kulmann @JammingBen