[full-ci] Webfinger redirect app #8884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
commented
Apr 20, 2023
kulmann
commented
Apr 20, 2023
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/35110/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/35110/tracing/space-members-can-be-invited-with-an-expiration-date-alice-2023-4-25-10-24-29.zip |
JammingBen
reviewed
Apr 25, 2023
AlexAndBear
requested changes
Apr 25, 2023
AlexAndBear
requested changes
Apr 25, 2023
|
SonarCloud Quality Gate failed. |
JammingBen
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new app which is responsible for performing an authenticated webfinger discovery and either redirecting the user to their ownCloud instance or showing a comprehensible error message.
In its current state the app is meant for being run in a standalone ownCloud Web deployment - the full fledged ocis instance is the redirect target after the webfinger discovery. ;-) I still decided to put the app into our mono-repo because in the future this will transition into a multi-tenancy instance selection and that makes sense to be run alongside our other apps then.
Related Issue
How Has This Been Tested?
Not at all, yet. Need to write unit tests...
Types of changes
Checklist:
Open tasks:
Followup tasks: