Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Skip the expiry date related e2e test #8905

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Apr 25, 2023

The skipped test started to fail because we have a bug in the calendar that the scroller will automatically scroll up while trying to select the end-of-the-month dates #7513 .
This PR skips the test so that it won't obstruct the CI

Also, read the comment below #8905 (comment)

Fixes: #8902

@SwikritiT SwikritiT self-assigned this Apr 25, 2023
@SwikritiT
Copy link
Contributor Author

SwikritiT commented Apr 25, 2023

I've skipped the test in this PR but I think we made a decision to not skip the tests in e2e (don't remember the exact reason). Or maybe it was a decision about not adding @skipOnOcis, @skipOnOC10 tags, either way, my memory is cloudy.
So I want to make sure that what's done in this PR is okay. If it's not, other paths we can follow is

  1. Comment out the test (which is equivalent to skipping)
  2. hard code the date to some distant future that'll be at the beginning of the month. (this is like dodging the bug but the bug is known and the test will also run throughout the month)

@individual-it @ScharfViktor @saw-jan

@SwikritiT SwikritiT marked this pull request as ready for review April 25, 2023 06:23
Co-authored-by: Phil Davis <phil@jankaritech.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT requested a review from phil-davis April 25, 2023 07:56
@ScharfViktor
Copy link
Contributor

I've skipped the test in this PR but I think we made a decision to not skip the tests in e2e (don't remember the exact reason). Or maybe it was a decision about not adding @skipOnOcis, @skipOnOC10 tags, either way, my memory is cloudy. So I want to make sure that what's done in this PR is okay. If it's not, other paths we can follow is

  1. Comment out the test (which is equivalent to skipping)
  2. hard code the date to some distant future that'll be at the beginning of the month. (this is like dodging the bug but the bug is known and the test will also run throughout the month)

@individual-it @ScharfViktor @saw-jan

honestly, I wouldn't skip test

Maybe increase page size? using await page.setViewportSize

Screen.Recording.2023-04-25.at.10.03.14.mov

@SwikritiT
Copy link
Contributor Author

SwikritiT commented Apr 25, 2023

Maybe increase page size? using await page.setViewportSize

yes, that would probably work but I want to make sure that we are well aware that we are just tiptoeing over the bug(which might be better than skipping it altogether?).
So I should increase the size? @ScharfViktor

@SwikritiT
Copy link
Contributor Author

By setting the viewport to

await page.setViewportSize({
    width: 1280,
    height: 800
  })

I can make the test pass locally

@kulmann
Copy link
Contributor

kulmann commented Apr 25, 2023

As soon as there are some shares / members in the list above the increased viewport height doesn't help anymore again... kind of prefer to skip it to unblock PRs against master.

Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need add --tags ~@skip in ocis too

@SwikritiT SwikritiT merged commit ca6eefb into master Apr 25, 2023
@delete-merged-branch delete-merged-branch bot deleted the debug/e2e-test-failing branch April 25, 2023 09:33
AlexAndBear pushed a commit that referenced this pull request Apr 25, 2023
* Skip the expiry date related e2e test

* fix grammar

Co-authored-by: Phil Davis <phil@jankaritech.com>

---------

Co-authored-by: Phil Davis <phil@jankaritech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA][OCIS]e2e test failing in nightly
4 participants