-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Skip the expiry date related e2e test #8905
Conversation
I've skipped the test in this PR but I think we made a decision to not skip the tests in e2e (don't remember the exact reason). Or maybe it was a decision about not adding
|
tests/e2e/cucumber/features/smoke/spaces/memberExpiry.ocis.feature
Outdated
Show resolved
Hide resolved
Co-authored-by: Phil Davis <phil@jankaritech.com>
Kudos, SonarCloud Quality Gate passed! |
honestly, I wouldn't skip test Maybe increase page size? using Screen.Recording.2023-04-25.at.10.03.14.mov |
yes, that would probably work but I want to make sure that we are well aware that we are just tiptoeing over the bug(which might be better than skipping it altogether?). |
By setting the viewport to
I can make the test pass locally |
As soon as there are some shares / members in the list above the increased viewport height doesn't help anymore again... kind of prefer to skip it to unblock PRs against master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need add --tags ~@skip
in ocis too
* Skip the expiry date related e2e test * fix grammar Co-authored-by: Phil Davis <phil@jankaritech.com> --------- Co-authored-by: Phil Davis <phil@jankaritech.com>
The skipped test started to fail because we have a bug in the calendar that the scroller will automatically scroll up while trying to select the end-of-the-month dates #7513 .
This PR skips the test so that it won't obstruct the CI
Also, read the comment below #8905 (comment)
Fixes: #8902