Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: forbid virtual spaces #9015

Merged
merged 1 commit into from
May 11, 2023
Merged

fix: forbid virtual spaces #9015

merged 1 commit into from
May 11, 2023

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented May 11, 2023

Description

Preventing access to virtual spaces. Otherwise it's possible to e.g. access the virtual shares space (virtual/shares), which we don't want because shares are handled differently in web.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann self-assigned this May 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

AlexAndBear
AlexAndBear approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy guacamoly 😇🥑

@kulmann kulmann merged commit b8349ea into stable-7.0 May 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the forbid-virtual-spaces branch May 11, 2023 10:20
@kulmann kulmann mentioned this pull request May 22, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

@lookacat lookacat Awaiting requested review from lookacat

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kulmann @AlexAndBear @JammingBen