Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resource not found and no content message both displayed #9062

Merged
merged 1 commit into from
May 22, 2023
Merged

fix: resource not found and no content message both displayed #9062

merged 1 commit into from
May 22, 2023

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented May 17, 2023

Description

Fixing two things:

  • "Resource not found" obtaining too much height (thus scroll bars were appearing)
  • "Resource not found" and "Empty folder" messages appearing at the same time

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann self-assigned this May 17, 2023
@fschade fschade self-requested a review May 19, 2023 09:03
fschade
fschade approved these changes May 19, 2023
View reviewed changes
Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulmann kulmann force-pushed the fix-not-found-no-content-duplication branch from 902ca0f to ea0c7c0 Compare May 19, 2023 13:07
@sonarcloud
Copy link

sonarcloud bot commented May 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 6afaa38 into stable-7.0 May 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-not-found-no-content-duplication branch May 22, 2023 07:36
@JammingBen JammingBen mentioned this pull request May 22, 2023
Closed
@JammingBen JammingBen mentioned this pull request Jun 7, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@fschade fschade fschade approved these changes

@lookacat lookacat Awaiting requested review from lookacat

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kulmann @fschade @JammingBen