Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search page breadcrumbs and advanced search icon #9077

Merged
merged 3 commits into from
May 24, 2023
Merged

Add search page breadcrumbs and advanced search icon #9077

merged 3 commits into from
May 24, 2023

Conversation

JammingBen
Copy link
Contributor

Related Issue

Screenshots:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this May 23, 2023
@JammingBen JammingBen force-pushed the search-page-title branch from f5c7cee to 56bc7d0 Compare May 23, 2023 11:43
@JammingBen JammingBen force-pushed the search-in-file-content branch from eb69237 to 6a8a5f6 Compare May 23, 2023 11:51
@delete-merged-branch delete-merged-branch bot deleted the branch master May 23, 2023 12:43
@JammingBen JammingBen changed the base branch from search-in-file-content to master May 23, 2023 12:45
@JammingBen JammingBen force-pushed the search-page-title branch from 56bc7d0 to ee35c42 Compare May 23, 2023 12:46
@owncloud owncloud deleted a comment from update-docs bot May 23, 2023
@JammingBen JammingBen marked this pull request as ready for review May 23, 2023 13:29
kulmann
kulmann approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

packages/web-app-files/src/components/Search/List.vue Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit ad30b26 into master May 24, 2023
@delete-merged-branch delete-merged-branch bot deleted the search-page-title branch May 24, 2023 06:57
@micbar micbar mentioned this pull request Jul 24, 2023
Closed
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Web] Show Advanced search icon
2 participants
@JammingBen @kulmann