Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some a11y fixes #9113

Merged
merged 6 commits into from
Jun 23, 2023
Merged

Some a11y fixes #9113

merged 6 commits into from
Jun 23, 2023

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented May 25, 2023

Some accessibility fixes

  • h1 tag in GenericSpace views was not filled
  • fix h-tag cascading / order
  • moved div meta element which is used for the left sidebar nav active item highlighting out of the ul (because divs are not allowed as children of ul)

@update-docs
Copy link

update-docs bot commented May 25, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann marked this pull request as ready for review May 30, 2023 11:45
@kulmann kulmann self-assigned this May 30, 2023
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it a bit, works fine. Code looks fine but can't really tell if its now more a11y conform.

@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit cf247bd into stable-7.0 Jun 23, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the some-a11y-fixes branch June 23, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants