Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: select-all checkbox checks items in other list #9131

Merged
merged 3 commits into from
May 30, 2023
Merged

Bugfix: select-all checkbox checks items in other list #9131

merged 3 commits into from
May 30, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented May 30, 2023 •
edited
Loading

Description

The problem was that we check if selectedIds.length equal the length of the resources inside the table. So if one item is selected in another table the statement will be true in all tables even so no item was selected.
See #9122

Related Issue

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Merge to master

@update-docs
Copy link

update-docs bot commented May 30, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review May 30, 2023 10:18
@sonarcloud
Copy link

sonarcloud bot commented May 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit ca2aaae into stable-7.0 May 30, 2023
@delete-merged-branch delete-merged-branch bot deleted the 9122-bugfix-select-all-checkbox branch May 30, 2023 12:54
@JammingBen JammingBen mentioned this pull request May 30, 2023
Closed
@JammingBen JammingBen mentioned this pull request Jun 7, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lookacat @kulmann @AlexAndBear