Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add login button #9178

Merged
merged 9 commits into from
Jun 7, 2023
Merged

Add login button #9178

merged 9 commits into from
Jun 7, 2023

Conversation

AlexAndBear
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jun 7, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear requested a review from lookacat June 7, 2023 09:18
@ownclouders
Copy link
Contributor

ownclouders commented Jun 7, 2023 •
edited
Loading

Results for e2e-tests oCIS-2 https://drone.owncloud.com/owncloud/web/36364/13/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36364/tracing/participant-management-alice-2023-6-7-10-32-42.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36364/tracing/participant-management-anonymous-2023-6-7-10-33-24.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36364/tracing/participant-management-brian-2023-6-7-10-32-53.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36364/tracing/participant-management-carol-2023-6-7-10-33-09.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36364/tracing/participant-management-david-2023-6-7-10-32-58.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36364/tracing/participant-management-edith-2023-6-7-10-33-03.zip

💥 The e2e-ocis tests pipeline failed. The build has been cancelled.

JammingBen
JammingBen reviewed Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and works well! A unit test to check if the unauthenticated menu shows would be nice though 🙂

packages/web-runtime/src/components/Topbar/UserMenu.vue Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 46b36ad into master Jun 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the ssues/9177 branch June 7, 2023 12:59
ownclouders pushed a commit that referenced this pull request Jun 7, 2023
Add login button (#9178)
3aeaae5
kulmann
kulmann reviewed Jun 7, 2023
View reviewed changes
packages/web-runtime/src/components/Topbar/UserMenu.vue
:width="32"
icon="user-add"
icon-fill-type="line"
icon-color="var(--oc-color-icon-text)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be oc-color-swatch-brand-default then? the contrast token is the contrast color for the default of the same swatch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check

kulmann
kulmann reviewed Jun 7, 2023
View reviewed changes
packages/web-runtime/src/components/Topbar/UserMenu.vue
type="router-link"
:to="loginLink"
>
<oc-icon name="user-add" fill-type="line" class="oc-p-xs" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong icon :trollface:

@micbar micbar mentioned this pull request Jul 24, 2023
Closed
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann left review comments

@JammingBen JammingBen JammingBen approved these changes

@lookacat lookacat Awaiting requested review from lookacat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] Privacy statement in account menu (not authenticated)
4 participants
@AlexAndBear @ownclouders @kulmann @JammingBen