[full-ci] Search batch actions #9200

AlexAndBear · 2023-06-12T05:12:25Z

Description

Related Issue

Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

test environment:
test case 1:
test case 2:
...

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

...

update-docs · 2023-06-12T05:12:30Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

lookacat

Code looks solid, changelog missing or followup? :)

AlexAndBear · 2023-06-12T07:11:53Z

@lookacat this is so early in progress -> no changelog and most of the stuff is missing or not working

packages/web-app-files/src/composables/actions/helpers/useFileActionsDeleteResources.ts

AlexAndBear · 2023-06-13T06:50:37Z

~~Todo: move getMatchingSpace to own composable.~~

AlexAndBear · 2023-06-14T08:27:35Z

~~Blocked by owncloud/ocis#6525 no permissions on resources in space -> canDelete results in false~~

packages/web-app-files/src/components/FilesList/ResourceTable.vue

AlexAndBear · 2023-06-14T14:49:02Z

~~check why trashbin is broken / does it work with personal and space trashbin (with build:w it works, but personal files will be shown as shared with me -.-)~~
~~move pasteActions store call stuff to composable (try to move the then stuff out)~~
~~check if delete batch action works on project space content when Add Permission to webdav REPORT ocis#6528 is merged~~
~~add changelog item~~
~~remove clipBoardSpace from store~~
add unit tests

ownclouders · 2023-06-14T15:07:35Z

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/36649/40/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L113.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L136.png

ownclouders · 2023-06-15T10:02:21Z

Results for e2e-tests oCIS-2 https://drone.owncloud.com/owncloud/web/36615/13/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-alice-2023-6-16-12-51-11.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-anonymous-2023-6-16-12-51-42.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-brian-2023-6-16-12-51-20.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-carol-2023-6-16-12-51-31.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-david-2023-6-16-12-51-23.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-edith-2023-6-16-12-51-27.zip

packages/web-app-files/src/components/FilesList/KeyboardActions.vue

AlexAndBear · 2023-06-16T08:27:51Z

packages/web-app-files/src/composables/actions/files/useFileActionsPaste.ts

+        )
+      }
+    )
+    return Promise.all(promises).then(() => {


enable conflict handling when 2 resources with same name from different spaces will be pasted -> keep both automatic

packages/web-app-files/src/composables/filesList/useResourceRouteResolver.ts

AlexAndBear · 2023-06-16T08:34:43Z

packages/web-app-files/src/store/actions.ts

@@ -99,39 +101,34 @@ export default {
      $ngettext,
      $gettextInterpolate
    )
-    let movedResources = []
+    let movedResourcesPromise
    if (context.state.clipboardAction === ClipboardActions.Cut) {


purge store action, move to composable in followup pr

packages/web-client/src/helpers/space/functions.ts

AlexAndBear · 2023-06-16T11:53:33Z

Scenario OCIS=true pnpm test:e2e:cucumber 'tests/e2e/cucumber/features/smoke/spaces/participantManagement.ocis.feature:3'
is failing.

Basically, that's deleting a resource in a public share that's inside a project space

AlexAndBear · 2023-06-16T12:09:39Z

packages/web-client/src/helpers/space/functions.ts

@@ -206,6 +206,9 @@ export function buildSpace(data): SpaceResource {
    isReceivedShare: function () {
      return false
    },
+    isShareRoot: function () {
+      return ['share', 'mountpoint'].includes(data.driveType)


what's with public?

ownclouders · 2023-06-16T12:57:08Z

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/36618/68/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L113.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L136.png

packages/web-pkg/src/composables/spaces/useGetMatchingSpace.ts

kulmann

👏 👏 👏

sonarqubecloud · 2023-06-19T14:44:41Z

SonarCloud Quality Gate failed.

1 Bug
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

49.7% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

lookacat

Good work <3

lookacat suggested changes Jun 12, 2023

View reviewed changes

AlexAndBear commented Jun 13, 2023

View reviewed changes

AlexAndBear force-pushed the search-batch-actions branch from 885a08b to aa28900 Compare June 14, 2023 12:16

AlexAndBear commented Jun 14, 2023

View reviewed changes

packages/web-app-files/src/components/FilesList/ResourceTable.vue Show resolved Hide resolved

AlexAndBear changed the title ~~Search batch actions~~ [full-ci] Search batch actions Jun 15, 2023

AlexAndBear commented Jun 15, 2023

View reviewed changes

packages/web-app-files/src/components/FilesList/KeyboardActions.vue Outdated Show resolved Hide resolved

AlexAndBear commented Jun 16, 2023

View reviewed changes

packages/web-app-files/src/composables/filesList/useResourceRouteResolver.ts Show resolved Hide resolved

AlexAndBear commented Jun 16, 2023

View reviewed changes

packages/web-client/src/helpers/space/functions.ts Outdated Show resolved Hide resolved

AlexAndBear force-pushed the search-batch-actions branch from f285c2f to 21746ce Compare June 16, 2023 11:44

AlexAndBear requested a review from kulmann June 16, 2023 11:53

AlexAndBear commented Jun 16, 2023

View reviewed changes

packages/web-pkg/src/composables/spaces/useGetMatchingSpace.ts Outdated Show resolved Hide resolved

Jan added 7 commits June 19, 2023 12:42

Add batch actions to search

83dace1

Add logic

35f556b

Disable delete on recived share

0d68b9d

Try to resolve space if not present

39279f8

Fix loading previews for search

2da5418

Fix

7f11ba6

Fix download archive on single files in search

c619333

Jan and others added 10 commits June 19, 2023 12:44

Fix trashbin

dbee20f

Rm unused store var clipboardSpace

531b85a

Rm unused store var clipboardSpace

69d87bf

Don't make actionFunc computed, as not needed

c5edcbc

lint

2443a30

Fix unit test

0cc4110

Bad quick fix

7f8bdac

Lint

ed95910

Fix

facf7d3

refactor: simplify useGetMatchingSpace usage

243f60a

kulmann force-pushed the search-batch-actions branch from 9f10624 to 89be4e9 Compare June 19, 2023 10:44

kulmann added 4 commits June 19, 2023 13:05

refactor: clean up getMatchingSpace for public links

ae23beb

feat: add 'public' to positive list of isShareRoot

86c882f

doc: add summary to changelog item

bebacec

refactor: use $gettext instead of v-translate

ad54541

kulmann force-pushed the search-batch-actions branch from 9023685 to ad54541 Compare June 19, 2023 11:05

Jan and others added 5 commits June 19, 2023 13:12

Fix unit tests

0472c75

refactor: simplify and fix checks in archive download

551a5e9

perf: early return when collecting source spaces (file actions)

df4664d

feat: remove debounce time for paste action

cc9d3c2

fix: getMatchingSpace for oc10

b63ed68

kulmann approved these changes Jun 19, 2023

View reviewed changes

Fix oc10 bug

f4da7e5

AlexAndBear marked this pull request as ready for review June 19, 2023 18:13

lookacat approved these changes Jun 19, 2023

View reviewed changes

AlexAndBear merged commit 42b3240 into master Jun 20, 2023

delete-merged-branch bot deleted the search-batch-actions branch June 20, 2023 10:37

ownclouders pushed a commit that referenced this pull request Jun 20, 2023

[full-ci] Search batch actions (#9200)

55c89cf

micbar mentioned this pull request Jul 24, 2023

Release 4.0.0 owncloud/ocis#6838

Closed

68 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[full-ci] Search batch actions #9200

[full-ci] Search batch actions #9200

AlexAndBear commented Jun 12, 2023

update-docs bot commented Jun 12, 2023

lookacat left a comment

AlexAndBear commented Jun 12, 2023 •

edited

Loading

AlexAndBear commented Jun 13, 2023 •

edited

Loading

AlexAndBear commented Jun 14, 2023 •

edited

Loading

AlexAndBear commented Jun 14, 2023 •

edited

Loading

ownclouders commented Jun 14, 2023 •

edited

Loading

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L113.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L136.png

ownclouders commented Jun 15, 2023 •

edited

Loading

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-alice-2023-6-16-12-51-11.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-anonymous-2023-6-16-12-51-42.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-brian-2023-6-16-12-51-20.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-carol-2023-6-16-12-51-31.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-david-2023-6-16-12-51-23.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-edith-2023-6-16-12-51-27.zip

AlexAndBear Jun 16, 2023 •

edited

Loading

AlexAndBear Jun 16, 2023 •

edited

Loading

AlexAndBear commented Jun 16, 2023

AlexAndBear Jun 16, 2023

ownclouders commented Jun 16, 2023 •

edited

Loading

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L113.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L136.png

kulmann left a comment

sonarqubecloud bot commented Jun 19, 2023

lookacat left a comment

[full-ci] Search batch actions #9200

[full-ci] Search batch actions #9200

Conversation

AlexAndBear commented Jun 12, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Open tasks:

update-docs bot commented Jun 12, 2023

lookacat left a comment

Choose a reason for hiding this comment

AlexAndBear commented Jun 12, 2023 • edited Loading

AlexAndBear commented Jun 13, 2023 • edited Loading

AlexAndBear commented Jun 14, 2023 • edited Loading

AlexAndBear commented Jun 14, 2023 • edited Loading

ownclouders commented Jun 14, 2023 • edited Loading

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L113.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L136.png

ownclouders commented Jun 15, 2023 • edited Loading

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-alice-2023-6-16-12-51-11.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-anonymous-2023-6-16-12-51-42.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-brian-2023-6-16-12-51-20.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-carol-2023-6-16-12-51-31.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-david-2023-6-16-12-51-23.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36615/tracing/participant-management-edith-2023-6-16-12-51-27.zip

AlexAndBear Jun 16, 2023 • edited Loading

Choose a reason for hiding this comment

AlexAndBear Jun 16, 2023 • edited Loading

Choose a reason for hiding this comment

AlexAndBear commented Jun 16, 2023

AlexAndBear Jun 16, 2023

Choose a reason for hiding this comment

ownclouders commented Jun 16, 2023 • edited Loading

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L113.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L136.png

kulmann left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jun 19, 2023

lookacat left a comment

Choose a reason for hiding this comment

AlexAndBear commented Jun 12, 2023 •

edited

Loading

AlexAndBear commented Jun 13, 2023 •

edited

Loading

AlexAndBear commented Jun 14, 2023 •

edited

Loading

AlexAndBear commented Jun 14, 2023 •

edited

Loading

ownclouders commented Jun 14, 2023 •

edited

Loading

ownclouders commented Jun 15, 2023 •

edited

Loading

AlexAndBear Jun 16, 2023 •

edited

Loading

AlexAndBear Jun 16, 2023 •

edited

Loading

ownclouders commented Jun 16, 2023 •

edited

Loading