feat: enforce prefix for persisted route query values #9226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pagination for admin-settings has been introduced recently. A weird-ish url query was used for the items per page:
admin-settings-items-per-page
. With this PR I'm streamlining that to beitems-per-page
in both theadmin-settings
andfiles
apps respectively by enforcing a prefix for persisting the query value into the localStorage. A kind of prefix already existed before: it was namedrouteName
, which is too specific, so I renamed it. As a result the items per page in the files app will be persisted intooc-options_files_items-per-page
and the items per page in the admin-settings app will be persisted intooc-options_admin-settings_items-per-page
.Motivation and Context
Consistency in a) localStorage, b) url query and c) developer experience
Types of changes
Checklist:
Open tasks: