Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cloud import into folder with special characters #9282

Merged
merged 1 commit into from
Jun 23, 2023
Merged

fix: cloud import into folder with special characters #9282

merged 1 commit into from
Jun 23, 2023

Conversation

JammingBen
Copy link
Contributor

Description

Fixes the cloud import when importing files into a folder that has special characters in its name.

Follow-up for #9150.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jun 22, 2023
@JammingBen JammingBen force-pushed the fix-special-character-cloud-import branch from 47d796e to 445375b Compare June 22, 2023 10:32
@JammingBen JammingBen marked this pull request as ready for review June 22, 2023 10:54
@JammingBen JammingBen requested a review from dschmidt June 22, 2023 10:54
dschmidt
dschmidt reviewed Jun 22, 2023
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe encode it just once here:
https://github.com/owncloud/web/blob/445375b3e488d15788755d36d190b03b3106eccd/packages/web-app-files/src/HandleUpload.ts#LL145C54-L145C63
?

@dschmidt
Copy link
Member

Does this fix #9247?

@JammingBen
Copy link
Contributor Author

maybe encode it just once here: https://github.com/owncloud/web/blob/445375b3e488d15788755d36d190b03b3106eccd/packages/web-app-files/src/HandleUpload.ts#LL145C54-L145C63 ?

That's the directory when uploading files that are located inside a folder (= when uploading a folder). The current folder path is trimmedUploadPath.

Does this fix #9247?

Unfortunately not. It won't create any files with cut-off names but it still fails with status code 500. Might be a server issue, not sure yet though.

@JammingBen
fix: cloud import into folder with special characters
8aa4903 
Fixes the cloud import when importing files into a folder that has special characters in its name.
@JammingBen JammingBen force-pushed the fix-special-character-cloud-import branch from 445375b to 8aa4903 Compare June 22, 2023 12:19
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit bc366ad into master Jun 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-special-character-cloud-import branch June 23, 2023 08:10
ownclouders pushed a commit that referenced this pull request Jun 23, 2023
@JammingBen
Merge pull request #9282 from owncloud/fix-special-character-cloud-im…
087f743 
…port

fix: cloud import into folder with special characters
@JammingBen JammingBen mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt approved these changes

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JammingBen @dschmidt