Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uploading to folders that contain special characters #9290

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

JammingBen
Copy link
Collaborator

Description

Fixes uploading resources to folders that contain special characters in their names. This also includes fixes for name conflict handling when running oC10 as server.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jun 23, 2023
@JammingBen JammingBen force-pushed the tus-upload-encoding branch 2 times, most recently from 6297c4a to 99c3e23 Compare June 23, 2023 12:58
@JammingBen JammingBen marked this pull request as ready for review June 23, 2023 13:07
@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/36779/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36779/tracing/public-link-alice-2023-6-23-01-10-39.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36779/tracing/public-link-anonymous-2023-6-23-01-11-05.zip

💥 The e2e-oc10 tests pipeline failed. The build has been cancelled.

Fixes uploading resources to folders that contain special characters in their names. This also includes fixes for name conflict handling when running oC10 as server.
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 5 Code Smells

12.0% 12.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@JammingBen JammingBen requested a review from dschmidt June 23, 2023 14:27
@JammingBen JammingBen merged commit bcd5057 into master Jul 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the tus-upload-encoding branch July 3, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"#" sign in directory name causes error by uploading files inside it
3 participants