Add location filter chip in search #9304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
lookacat
changed the title
|
The glitch when selecting a different location scope while the search page is open is related to the backend not yet working, it just stops the update of the component for some reason. So probably fixed as soon as the backend works. |
lookacat
force-pushed
the
add-location-filter-search
branch
from
fdf1302
to
a95f0e2
Compare
JammingBen
requested changes
Jul 11, 2023
packages/design-system/src/components/OcSearchBarFilter/OcSearchBarFilter.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/OcSearchBarFilter/OcSearchBarFilter.vue
Outdated
Show resolved
Hide resolved
Comment on lines
+131
to
+151
| const availableLocationOptions = ref([ | ||
| { | ||
| title: $gettext('All Files'), | ||
| id: SearchLocationFilterConstants.allFiles, | ||
| enabled: true, | ||
| default: false | ||
| }, | ||
| { | ||
| title: $gettext('Current Folder'), | ||
| id: SearchLocationFilterConstants.currentFolder, | ||
| enabled: currentFolderAvailable, | ||
| default: true | ||
| } | ||
| ]) |
There was a problem hiding this comment.
Would be nice to have a type somewhere so we can re-use it across the app.
lookacat
force-pushed
the
add-location-filter-search
branch
2 times, most recently
from
4b70f06
to
7f8f62b
Compare
lookacat
force-pushed
the
add-location-filter-search
branch
from
d31e1c5
to
d02010f
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #9258
Related Issue
Types of changes
Checklist: