"Shared with me" view: switch columns displayed on small screens #9320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eens proposed solution for issue #9315
koebel
added
Status:Needs-Review
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
|
JammingBen
reviewed
Jun 29, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
delete-merged-branch
bot
deleted the
display/hide-columns-for-“shared-with-me”-view-on-small-screens
branch
koebel
restored the
display/hide-columns-for-“shared-with-me”-view-on-small-screens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously in the "Shared with me" view the column "Shared by" was hidden whereas the column "Shared with" was displayed on small screens and tablets (screen size <1200px). I switched the visibility of these two columns for this particular view.
Related Issue
Motivation and Context
As a user, when browsing though files shared with me, it would be more interesting to see who shared a resource with me than with whom it was shared since "Shared with" is always the user himself (or a group he/she is part of). Previously the column "Shared by" was hidden whereas the column "Shared with" was displayed on small screens and tablets (screen size <1200px). With the proposed changes the visibility of these two columns are changed for the specified screen sizes for this particular view.
How Has This Been Tested?
manual testing using the Chrome inbuilt simulator of various mobile devices and screen sizes
Screenshots (if appropriate):
proposed solution:
Types of changes
Checklist:
Open tasks: