Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9224 comma separation #9348

Merged
merged 6 commits into from
Jul 12, 2023
Merged

9224 comma separation #9348

merged 6 commits into from
Jul 12, 2023

Conversation

grimmoc
Copy link
Contributor

@grimmoc grimmoc commented Jul 5, 2023

Description

Tags containing commas are now split up into separate tags on client side to match server side processing behaviour.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@tbsbdr tbsbdr mentioned this pull request Jul 6, 2023
Closed
@grimmoc grimmoc force-pushed the 9224-comma-separation branch from ce27564 to 4f0b321 Compare July 11, 2023 09:13
@grimmoc grimmoc requested a review from JammingBen July 11, 2023 09:17
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

JammingBen
JammingBen approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JammingBen JammingBen marked this pull request as ready for review July 12, 2023 11:13
@JammingBen JammingBen merged commit b35cce3 into master Jul 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the 9224-comma-separation branch July 12, 2023 11:13
ownclouders pushed a commit that referenced this pull request Jul 12, 2023
@grimmoc
9224 comma separation (#9348)
8986a6c 
* changed event firing behaviour for select on tags input
@JammingBen JammingBen mentioned this pull request Jul 12, 2023
Closed
@micbar micbar mentioned this pull request Jul 24, 2023
Closed
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann left review comments

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grimmoc @kulmann @JammingBen