Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use env var to determine session or local storage #9386

Merged
merged 9 commits into from
Jul 12, 2023
Merged

Use env var to determine session or local storage #9386

merged 9 commits into from
Jul 12, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jul 11, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jul 11, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear requested a review from JammingBen July 11, 2023 11:39
@AlexAndBear AlexAndBear marked this pull request as ready for review July 11, 2023 12:13
@AlexAndBear AlexAndBear requested a review from dschmidt July 11, 2023 14:32
JammingBen
JammingBen reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Please add tokenStorageLocal to the documented options in getting-started.md.

@AlexAndBear AlexAndBear requested a review from JammingBen July 12, 2023 07:33
JammingBen
JammingBen reviewed Jul 12, 2023
View reviewed changes
docs/getting-started.md Outdated Show resolved Hide resolved
@JammingBen
Update docs/getting-started.md
e4a5835 
Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
@AlexAndBear AlexAndBear requested a review from JammingBen July 12, 2023 10:01
JammingBen
JammingBen approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice 🚀

@AlexAndBear AlexAndBear enabled auto-merge (squash) July 12, 2023 10:03
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 30cc498 into master Jul 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the issues/9325 branch July 12, 2023 10:35
ownclouders pushed a commit that referenced this pull request Jul 12, 2023
Use env var to determine session or local storage (#9386)
da09864
@micbar micbar mentioned this pull request Jul 24, 2023
Closed
68 tasks
@renovate renovate bot mentioned this pull request Oct 31, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] unify link behaviour across tabs
2 participants
@AlexAndBear @JammingBen