Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-only] Change purge trashbin test #9395

Merged
merged 1 commit into from
Jul 12, 2023
Merged

[test-only] Change purge trashbin test #9395

merged 1 commit into from
Jul 12, 2023

Conversation

ScharfViktor
Copy link
Contributor

after #9389 I changed e2e test where I check that:

  • viewer and editor cannot delete resource from space and manager can
  • I cleaned up some unused code

@update-docs
Copy link

update-docs bot commented Jul 12, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

AlexAndBear
AlexAndBear approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥰

@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ScharfViktor ScharfViktor merged commit b8e3e1d into master Jul 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the changePurgeTrashBinTest branch July 12, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@grgprarup grgprarup Awaiting requested review from grgprarup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScharfViktor @AlexAndBear