Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme switcher for more themes #9396

Closed
wants to merge 4 commits into from

Conversation

elizavetaRa
Copy link
Member

@elizavetaRa elizavetaRa commented Jul 12, 2023

Description

The pr adds the possibility to switch between themes when there are more than 2.

Related Issue

  • Fixes <issue_link>

Motivation and Context

Improving the accessibility by providing high contrast themes in addition to classical default and default dark

Screenshots (if appropriate):

Screenshot from 2023-07-12 12-17-20

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jul 12, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@elizavetaRa
Copy link
Member Author

@tbsbdr
To discuss:

  • icon (selected "paint", alternative: "paint-brush")
  • Need of heading (I personally like with it to clarify the purpose)
  • With heading looks better in card optic, without it could be done like roles menu

For further pr's: themes, theme names

@elizavetaRa elizavetaRa mentioned this pull request Jul 12, 2023
10 tasks
@pascalwengerter
Copy link
Contributor

Closing in favor of #9698, thanks for the initiative!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants