Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error log to upload service #9436

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Add error log to upload service #9436

merged 6 commits into from
Jul 19, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jul 18, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jul 18, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

AlexAndBear
AlexAndBear commented Jul 18, 2023
View reviewed changes
packages/web-runtime/src/components/UploadInfo.vue Outdated Show resolved Hide resolved
packages/web-runtime/src/components/UploadInfo.vue
@@ -657,6 +677,10 @@ export default defineComponent({
overflow-y: auto;
}

.upload-info-items.has-errors {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep height consistent

JammingBen
JammingBen approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The margin-top of the error box could be a bit less IMO, but not a deal breaker for me. Nice!

@AlexAndBear
Copy link
Contributor Author

The margin-top of the error box could be a bit less IMO, but not a deal breaker for me. Nice!

Yes, that's the same for notifications (l). I don't have any issues changing that to m

@AlexAndBear AlexAndBear enabled auto-merge (squash) July 19, 2023 09:41
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@AlexAndBear AlexAndBear merged commit f447198 into master Jul 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the issues/9430 branch July 19, 2023 11:14
AlexAndBear pushed a commit that referenced this pull request Aug 2, 2023
Add error log to upload service (#9436)
96c2068 
* Add error log to upload service

* Add changelog item

* Rm not needed surrounding div

* add computed

* Fix styling

* Fix spacing
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@AlexAndBear
Add error log to upload service (#9436)
741c2b4 
* Add error log to upload service

* Add changelog item

* Rm not needed surrounding div

* add computed

* Fix styling

* Fix spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] provide technical info for upload-errors
2 participants
@AlexAndBear @JammingBen