Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use spaces endpoint for search #9500

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Use spaces endpoint for search #9500

merged 3 commits into from
Aug 1, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jul 31, 2023 •
edited
Loading

Description

Doesn't change anything about the logic, we just call another endpoint to be rfc compliant but this will call the same code in the backend

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jul 31, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear marked this pull request as ready for review July 31, 2023 12:59
@JammingBen JammingBen merged commit 2695720 into master Aug 1, 2023
@delete-merged-branch delete-merged-branch bot deleted the issues/9367 branch August 1, 2023 08:27
AlexAndBear pushed a commit that referenced this pull request Aug 15, 2023
Use spaces endpoint for search (#9500)
ef2fef7 
* Use new spaces endpoint for search

* Bump sdk and ocis commit id

* Add spaces check
@fschade fschade mentioned this pull request Sep 5, 2023
Merged
8 tasks
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@AlexAndBear
Use spaces endpoint for search (#9500)
150167c 
* Use new spaces endpoint for search

* Bump sdk and ocis commit id

* Add spaces check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@lookacat lookacat Awaiting requested review from lookacat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search should send report to /dav/spaces to be compliant to the rfc
2 participants
@AlexAndBear @JammingBen