-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement file locking information #9566
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
9 tasks
lookacat
force-pushed
the
display-locking-information
branch
from
August 16, 2023 11:30
0ebda0a
to
7b8148f
Compare
lookacat
force-pushed
the
display-locking-information
branch
from
August 22, 2023 10:47
799f84b
to
3fbdcdf
Compare
AlexAndBear
reviewed
Aug 22, 2023
packages/design-system/src/components/OcResource/OcResource.vue
Outdated
Show resolved
Hide resolved
AlexAndBear
reviewed
Aug 22, 2023
AlexAndBear
reviewed
Aug 22, 2023
packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
Outdated
Show resolved
Hide resolved
AlexAndBear
requested changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, besides retrieving the lock user data
AlexAndBear
requested changes
Aug 23, 2023
AlexAndBear
requested changes
Aug 23, 2023
packages/web-app-files/src/composables/actions/files/useFileActionsDelete.ts
Show resolved
Hide resolved
packages/web-app-files/src/composables/actions/files/useFileActionsMove.ts
Show resolved
Hide resolved
packages/web-app-files/src/composables/actions/files/useFileActionsRename.ts
Show resolved
Hide resolved
AlexAndBear
requested changes
Aug 23, 2023
packages/design-system/src/components/OcResource/OcResource.vue
Outdated
Show resolved
Hide resolved
AlexAndBear
approved these changes
Aug 23, 2023
Kudos, SonarCloud Quality Gate passed! |
ownclouders
pushed a commit
that referenced
this pull request
Aug 24, 2023
* Implement file locking information * Implement lock in files-table (ugly) * Implement lock owner in buildResource * Display lock owner * remove lock column * Add changelog * Add tooltip to reflect status * Add aria label * Disable move, delete, rename for locked files * Address PR issues, add lock file * Remove lockowner from details (for now) * Fix misreplaced code * Now i found the right code to remove * Add unittests * remove unused prop in test * Fix acceptance tests
This was referenced Oct 10, 2023
12 tasks
AlexAndBear
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Implement file locking information * Implement lock in files-table (ugly) * Implement lock owner in buildResource * Display lock owner * remove lock column * Add changelog * Add tooltip to reflect status * Add aria label * Disable move, delete, rename for locked files * Address PR issues, add lock file * Remove lockowner from details (for now) * Fix misreplaced code * Now i found the right code to remove * Add unittests * remove unused prop in test * Fix acceptance tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #6682
Related Issue
Types of changes
Checklist:
Open tasks: