-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DICOM Viewer Extension (WIP) #9615
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and fix unsaved changes dialog
…n found ... and handle multiple registered actions for bound keys
Dicom image metadata display
display metadata in ui for other information
display metadata in ui for other information
…bel/web into DICOM-image-metadata-display
display metadata for other information in UI
merging current state of UI implementation (toolbar, metadata sidebar) into baseline of the app
With the dicom viewer prototype living in its own repo now, can we close this PR? :-) |
yes, let's close this. we've moved all the code to the new repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
web-app-dicom-viewer is an ocis web extension to preview DICOM files (medical images) and their corresponding metadata in the browser in the browser. The preview of the medical images is based on MIT licensed cornerstone3D.
The current implementation allows to preview .dcm files and display their corresponding metadata in a sidebar on request. It offers operations such as zoom, rotate, flip, invert and reset of the image preview. The UI is implemented in responsive manner and adapts to the device size regarding size of image preview and way how metadata is displayed.
important: codebase of current state of implementation has been moved from my own fork into the newly created repo on https://github.com/owncloud/web-app-dicom-viewer
Related Issue
Motivation and Context
The package allows to preview .dcm files and their corresponding meta information in the in the browser, based on cornerstone3D.js. This is very handy for the end user since they do no longer need to install another app just to preview medical images of this file type. Some competitors have similar extensions (see https://github.com/ayselafsar/dicomviewer), although their implementation is based on the predecessor version of cornerstone.js (https://github.com/cornerstonejs/cornerstone)
How Has This Been Tested?
Screenshots (if appropriate):
TBA
Types of changes
Checklist:
Open tasks:
Testing
UI/UX
implement additional features:
cornerstone3D would also support the preview of series of images, rendering volumes thereof and editing files (annotating & segmenting data) as well as saving these modifications. However we don't see a benefit of implementing these functionalities for the envisioned use cases at the moment. If a use case with these functionalities becomes relevant in the future, the following tasks would result: