Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DICOM Viewer Extension (WIP) #9615

Closed
wants to merge 182 commits into from

Conversation

koebel
Copy link
Contributor

@koebel koebel commented Aug 25, 2023

Description

web-app-dicom-viewer is an ocis web extension to preview DICOM files (medical images) and their corresponding metadata in the browser in the browser. The preview of the medical images is based on MIT licensed cornerstone3D.

The current implementation allows to preview .dcm files and display their corresponding metadata in a sidebar on request. It offers operations such as zoom, rotate, flip, invert and reset of the image preview. The UI is implemented in responsive manner and adapts to the device size regarding size of image preview and way how metadata is displayed.

important: codebase of current state of implementation has been moved from my own fork into the newly created repo on https://github.com/owncloud/web-app-dicom-viewer

Related Issue

Motivation and Context

The package allows to preview .dcm files and their corresponding meta information in the in the browser, based on cornerstone3D.js. This is very handy for the end user since they do no longer need to install another app just to preview medical images of this file type. Some competitors have similar extensions (see https://github.com/ayselafsar/dicomviewer), although their implementation is based on the predecessor version of cornerstone.js (https://github.com/cornerstonejs/cornerstone)

How Has This Been Tested?

  • automated testing for unit tests (WiP)
  • manual testing for UI design and responsive behaviour

Screenshots (if appropriate):

TBA

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

Testing

  • implement remaining test cases

UI/UX

  • align UI design to overall oC design
  • make UI responsive to various screen sizes
  • adding translations?

implement additional features:

  • display all meta data of current file
  • allow to display prev/next image for files that are in the same folder (wait until the same functionality of web-app-preview is refactored using streamlined app interface)

cornerstone3D would also support the preview of series of images, rendering volumes thereof and editing files (annotating & segmenting data) as well as saving these modifications. However we don't see a benefit of implementing these functionalities for the envisioned use cases at the moment. If a use case with these functionalities becomes relevant in the future, the following tasks would result:

  • displaying stack of images (multiple files belonging to a series)
  • rendering volumes of a series of files
  • advanced image manipulation tools
  • annotation tools
  • segmentation tools

pascalwengerter and others added 30 commits August 3, 2023 21:15
…n found

... and handle multiple registered actions for bound keys
koebel and others added 27 commits October 12, 2023 15:50
display metadata in ui for other information
display metadata in ui for other information
display metadata for other information in UI
merging current state of UI implementation (toolbar, metadata sidebar) into baseline of the app
@kulmann
Copy link
Member

kulmann commented Jan 3, 2024

With the dicom viewer prototype living in its own repo now, can we close this PR? :-)

@koebel
Copy link
Contributor Author

koebel commented Jan 18, 2024

With the dicom viewer prototype living in its own repo now, can we close this PR? :-)

yes, let's close this. we've moved all the code to the new repo

@koebel koebel closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants