Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboard navigation to spaces #9625

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Add keyboard navigation to spaces #9625

merged 4 commits into from
Aug 31, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Aug 29, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@AlexAndBear AlexAndBear requested review from grimmoc and fschade August 29, 2023 10:29
fschade
fschade approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks good, i noticed a little thing while testing, i'm just making a video. Your decision whether blocker or not

changelog/unreleased/enhancement-add-keyboard-navigation-to-spaces Outdated Show resolved Hide resolved
changelog/unreleased/enhancement-add-keyboard-navigation-to-spaces Outdated Show resolved Hide resolved
@fschade
Copy link
Contributor

fschade commented Aug 31, 2023 •
edited
Loading

if i navigate to a space with the keyboard, press tab again at the point where the preview is active, the focus ends up in nirvana, after another click the title is selected.

means: 3 tabs are necessary to get from the preview to the title, i hope you get the point, hard to show in the vid.

Bildschirmaufnahme.2023-08-31.um.08.58.07.mp4

@AlexAndBear
Copy link
Contributor Author

@fschade

flo2.mp4

I can't reproduce it on my system (see Video). Furthermore this is not related to keyboard actions (or how it is implemented), could you please go to "All Files" change to tiles view and try to reproduce it there as well? I'd like you to open a new Issue with the video and give some background information about your system and browser

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.0% 84.0% Coverage
0.0% 0.0% Duplication

@fschade
Copy link
Contributor

fschade commented Aug 31, 2023 •
edited
Loading

me moron, i focused on tab navigation, LGTM, i open a new issue for that....

done: #9633

@AlexAndBear AlexAndBear merged commit e4fe75a into master Aug 31, 2023
@delete-merged-branch delete-merged-branch bot deleted the issues/9624 branch August 31, 2023 08:46
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@AlexAndBear
Add keyboard navigation to spaces (#9625)
d08e786 
* Add keyboard navigation to spaces

* Update changelog item

* Lint

* Add changelog item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grimmoc grimmoc grimmoc approved these changes

@fschade fschade fschade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] keyboard navigation in Spaces overview
3 participants
@AlexAndBear @fschade @grimmoc