Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce new ux for edit/remove expiration date for share links #9706

Merged
merged 11 commits into from
Sep 19, 2023
Merged

Introduce new ux for edit/remove expiration date for share links #9706

merged 11 commits into from
Sep 19, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Sep 18, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Sep 18, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title Introduce new ux for edit/remove password for file links Introduce new ux for edit/remove password for share links Sep 18, 2023
@AlexAndBear AlexAndBear changed the title Introduce new ux for edit/remove password for share links Introduce new ux for edit/remove expiration date for share links Sep 18, 2023
JammingBen
JammingBen reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing the same for regular people shares, no?

@AlexAndBear
Copy link
Contributor Author

It's missing the same for regular people shares, no?

I thought this was already part of the former implementation :D :D :D

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

37.5% 37.5% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear enabled auto-merge (squash) September 19, 2023 08:38
@AlexAndBear AlexAndBear merged commit 1f9fba8 into master Sep 19, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issues/9705 branch September 19, 2023 08:40
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@AlexAndBear
Introduce new ux for edit/remove expiration date for share links (#9706)
0fa2e9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@lookacat lookacat Awaiting requested review from lookacat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] Expiration Date: Unify Menu Item
2 participants
@AlexAndBear @JammingBen