Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load login url from config #9710

Merged
merged 3 commits into from
Sep 26, 2023
Merged

load login url from config #9710

merged 3 commits into from
Sep 26, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Sep 20, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Sep 20, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

This was referenced Sep 20, 2023
Closed
Merged
@CLAassistant
Copy link

CLAassistant commented Sep 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JammingBen
Copy link
Contributor

Approved, unit tests would be a nice thing though 🙂

@AlexAndBear
Copy link
Contributor Author

Ok, I'll add those

@AlexAndBear AlexAndBear enabled auto-merge (squash) September 26, 2023 18:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.8% 84.8% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit ba6247c into master Sep 26, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issues/9707-2 branch September 26, 2023 19:03
ownclouders pushed a commit that referenced this pull request Sep 26, 2023
@AlexAndBear
load login url from config (#9710)
1b8f957
AlexAndBear added a commit that referenced this pull request Dec 13, 2023
@AlexAndBear
load login url from config (#9710)
f3a25f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@lookacat lookacat Awaiting requested review from lookacat

@grimmoc grimmoc Awaiting requested review from grimmoc

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] Make "Login again" Button configurable
4 participants
@AlexAndBear @CLAassistant @JammingBen @dschmidt