Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generate password doesnt reset banned password error, autofocus on password input doesn't work #9735

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Fix generate password doesnt reset banned password error, autofocus on password input doesn't work #9735

merged 3 commits into from
Sep 27, 2023

Conversation

AlexAndBear
Copy link
Contributor

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Sep 27, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title Fix generate password doesnt reset banned password error Fix generate password doesnt reset banned password error, autofocus on password input doesn Sep 27, 2023
@AlexAndBear AlexAndBear changed the title Fix generate password doesnt reset banned password error, autofocus on password input doesn Fix generate password doesnt reset banned password error, autofocus on password input doesn't work Sep 27, 2023
lookacat
lookacat suggested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@lookacat lookacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Append this PR to changelog pls

JammingBen
JammingBen approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlexAndBear AlexAndBear enabled auto-merge (squash) September 27, 2023 09:32
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit d27dbe2 into master Sep 27, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the general-password-policy-followup branch September 27, 2023 10:01
AlexAndBear added a commit that referenced this pull request Dec 13, 2023
@AlexAndBear
Fix generate password doesnt reset banned password error, autofocus o…
9025a89 
…n password input doesn't work (#9735)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@lookacat lookacat lookacat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexAndBear @lookacat @JammingBen