[full-ci] [test-only] enable auto-accepting in e2e and UI test

[ScharfViktor]

part of owncloud/ocis#7241

I enabled FRONTEND_AUTO_ACCEPT_SHARES: true by defaultt

e2e test: first commit

• added api step to disable auto-accepting
• deleted accept share steps. some tests use UI accepting step to check accepting resources
• deleted step accepts the following share using API

ui test: second commit

• deleted accept share steps.
• deleted some skipped test. related Skipped oCIS tests for sharing jail #6896

found bugs:

• No redirect to shares with me page while opening internal link in case auto_accept_share #9776
• backend: how enabled auto-accepting again? - double values in the values-list POST https://host.docker.internal:9200/api/v0/settings/values-list
• backend: when autoaccepting is enable -> new dav doesn't return any resources more details here New dav doesn't return resources if auto accepting enabled ocis#7440 - that is the reason failed UI tests

TODO

• delete steps from middleware user "Alice" has accepted the share "Shares/lorem.txt" offered by user "Brian" in the server and And user "Carol" accepts the share "Shares/simple-folder" offered by user "Alice" using the sharing API in the server
• the setting "shareapi_auto_accept_share" of app "core" has been set to "no" in the server

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[ScharfViktor]

Failed steps:

• And user "Alice" has shared folder "/Shares/simple-folder" with user "Carol" in the server
• And the content of file "Shares/randomfile.txt" for user "Brian" should be "Carol file" in the server
• And user "Alice" has shared folder "/Shares/simple-folder" with user "Carol" with "read, delete" permissions in the server

middleware uses new dav path where some endpoints don't work like here: owncloud/ocis#7440

web uses space dav so webUI steps work.

I see three ways to get a "green" CI:

• wait for the fix New dav doesn't return resources if auto accepting enabled ocis#7440
• change the middleware to use space dav (check first: oc10 should not use these steps)
• skip these steps temporarily

[saw-jan]

Generally, looks good 👍

[saw-jan]

• wait for the fix

Would be great if dev team could make a fix (I would vote for this one if the fix can be quick)

• change the middleware to use space dav (check first: oc10 should not use these steps)

We don't know how this change could affect other test scenarios

• skip these steps temporarily

We could put those failing tests in expected failure list and we would know if the issue is fixed when we do ocis bump - tests should pass. (I would go for this as second option)

[SwikritiT]

• wait for the fix

Would be great if dev team could make a fix (I would vote for this one if the fix can be quick)

• change the middleware to use space dav (check first: oc10 should not use these steps)

We don't know how this change could affect other test scenarios

• skip these steps temporarily

We could put those failing tests in expected failure list and we would know if the issue is fixed when we do ocis bump - tests should pass. (I would go for this as second option)

If the fix won't be soon then I would also vote for keeping the failing tests in expected to fail and merging this PR

[ScharfViktor]

There's a fix coming soon cs3org/reva#4244 so I'm waiting.

[ScharfViktor]

CI is green. could you have look

[SwikritiT]

File changed shows 141 files changes is that correct?

[ScharfViktor]

File changed shows 141 files changes is that correct?

no, that was a bad rebase. Now is good

[saw-jan]

LGTM 👍 ✨

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication