Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate file editors application menu #9809

Merged
merged 48 commits into from
Oct 23, 2023
Merged

Integrate file editors application menu #9809

merged 48 commits into from
Oct 23, 2023

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Oct 16, 2023 •
edited
Loading

Description

See #9807

Related Issue

Screenshots:

Screenshot (81)
Screenshot (83)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Oct 16, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear force-pushed the integrate-file-editors-application-menu branch from a0d3f7a to ae84c52 Compare October 17, 2023 11:05
AlexAndBear
AlexAndBear reviewed Oct 18, 2023
View reviewed changes
tests/e2e/support/objects/runtime/application.ts
@@ -21,8 +21,9 @@ export class Application {
}

async open({ name }: { name: string }): Promise<void> {
await this.#page.waitForTimeout(1000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might need to find a better way

@lookacat lookacat marked this pull request as ready for review October 18, 2023 14:05
@AlexAndBear AlexAndBear force-pushed the integrate-file-editors-application-menu branch from 8e67539 to 527ec1e Compare October 19, 2023 08:38
JammingBen
JammingBen reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! Few minor things I've found, also:

  • The parent folder name seems to be wrong for files inside the root of a received share
  • Opening the preview app throws console errors, closing the app breaks Web

packages/web-runtime/src/App.vue Outdated Show resolved Hide resolved
packages/web-runtime/src/App.vue Outdated Show resolved Hide resolved
packages/web-runtime/src/components/Topbar/ApplicationsMenu.vue Outdated Show resolved Hide resolved
packages/web-runtime/src/components/Topbar/ApplicationsMenu.vue Outdated Show resolved Hide resolved
packages/web-runtime/src/components/Topbar/ApplicationsMenu.vue Outdated Show resolved Hide resolved
packages/web-runtime/src/components/Topbar/ApplicationsMenu.vue Outdated Show resolved Hide resolved
packages/web-runtime/src/components/Topbar/ApplicationsMenu.vue Outdated Show resolved Hide resolved
packages/web-pkg/src/helpers/router/routeOptions.ts Outdated Show resolved Hide resolved
@AlexAndBear
Copy link
Contributor

Awesome stuff! Few minor things I've found, also:

  • The parent folder name seems to be wrong for files inside the root of a received share
  • Opening the preview app throws console errors, closing the app breaks Web

Both have been fixed, but we won't show the parentFolderLink in the AppTopBar if the file is a received share due to the original shared folder name is not resolvable for now.

@AlexAndBear AlexAndBear force-pushed the integrate-file-editors-application-menu branch from 308f839 to 6daa77e Compare October 23, 2023 07:47
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

48.2% 48.2% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@AlexAndBear AlexAndBear merged commit d8b2349 into master Oct 23, 2023
1 of 2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the integrate-file-editors-application-menu branch October 23, 2023 14:13
LukasHirt pushed a commit to LukasHirt/web that referenced this pull request Oct 25, 2023
@lookacat @LukasHirt
Integrate file editors application menu (owncloud#9809)
901dfeb 
* Integrate file editors in application menu
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@lookacat @AlexAndBear
Integrate file editors application menu (#9809)
fd9b711 
* Integrate file editors in application menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear left review comments

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate file editors in application menu
3 participants
@lookacat @AlexAndBear @JammingBen