MVP - Modified Chip Filter #9831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
10 tasks
JammingBen
reviewed
Oct 25, 2023
There was a problem hiding this comment.
Please also add q_lastModified to https://github.com/owncloud/web/blob/master/packages/web-pkg/src/router/common.ts#L30. This ensures the filter stays active after opening and closing a file editor from the search result list.
Rest LGTM, very nice! And unit tests 🙌
P.S. I believe there is no reason for this PR to be in a draft state anymore? ;)
|
please:
|
fschade
reviewed
Oct 25, 2023
|
Kudos, SonarCloud Quality Gate passed! |
ownclouders
pushed a commit
that referenced
this pull request
Oct 25, 2023
* mvp, wip * added unit test * added loading from capabilities + adjusted tests accordingly * clean up, added changelog * added route query param to persistence list
12 tasks
AlexAndBear
pushed a commit
that referenced
this pull request
Dec 13, 2023
* mvp, wip * added unit test * added loading from capabilities + adjusted tests accordingly * clean up, added changelog * added route query param to persistence list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added a "last modified" filter chip in search to narrow down results based on last modified date.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: