Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change to the search query triggers only one request #9880

Merged
merged 1 commit into from
Oct 29, 2023
Merged

chore: change to the search query triggers only one request #9880

merged 1 commit into from
Oct 29, 2023

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Oct 29, 2023 •
edited
Loading

Description

add test to validate that search queries only emit a search request if one of the params had changed

Related Issue

Motivation and Context

have query changes tested

How Has This Been Tested?

  • unit test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@fschade fschade added Status:Needs-Review Needs review from a maintainer Type:CI Related to our Continouus Integration Solution labels Oct 29, 2023
@fschade fschade self-assigned this Oct 29, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AlexAndBear AlexAndBear merged commit 35a5e61 into master Oct 29, 2023
@delete-merged-branch delete-merged-branch bot deleted the test-duplicated-search-request branch October 29, 2023 19:49
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@fschade @AlexAndBear
chore: add test to validate that search queries only emit a search re…
3bcc7d5 
…quest if one of the params changes (#9880)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

Assignees

@fschade fschade

Labels
Status:Needs-Review Needs review from a maintainer Type:CI Related to our Continouus Integration Solution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fschade @AlexAndBear