Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable dark theme on uppy importer #9884

Merged
merged 2 commits into from
Oct 30, 2023
Merged

enable dark theme on uppy importer #9884

merged 2 commits into from
Oct 30, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Oct 30, 2023 •
edited
Loading

Description

image

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Oct 30, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear marked this pull request as ready for review October 30, 2023 08:06
dschmidt
dschmidt reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really prefer if we could

a) not hardcode the localStorage key in an app
I suggest a composable in web-pkg
b) not hardcode a specific theme name to check against
I suggest to add a property to the theme that says whether it's light or dark, as I commented in the original issue

@AlexAndBear
Copy link
Contributor Author

@dschmidt I merge this and we could check together if we can build something together, ok?

Because Jannik and me agreed that we don't want to kick up a shindy

@dschmidt
Copy link
Member

Yeah, go ahead. I didn't request changes for a reason 👍

But let's do it soon before we forget...

@AlexAndBear AlexAndBear enabled auto-merge (squash) October 30, 2023 09:01
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen mentioned this pull request Oct 30, 2023
Closed
@AlexAndBear AlexAndBear merged commit d1be562 into master Oct 30, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issues/9452 branch October 30, 2023 09:27
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
AlexAndBear added a commit that referenced this pull request Dec 13, 2023
@AlexAndBear
enable dark theme on uppy importer (#9884)
ec08cc9 
* enable dark theme on uppy importer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt left review comments

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cloud import] Dark theme does not apply to uppy dashboard
3 participants
@AlexAndBear @dschmidt @JammingBen