move tags to details panel #9905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
@JammingBen this is a first working draft, I would suggest refactoring the oc-select with all the tags stuff into an own component again. Also, I will probably be able to handle the tag search redirection by wrapping the in in a router link. It's a little ugly right now with the click event handler - although it works. Tests will need to be adjusted as well. |
lookacat
reviewed
Nov 3, 2023
lookacat
reviewed
Nov 3, 2023
packages/web-app-files/src/components/SideBar/Details/FileDetails.vue
Outdated
Show resolved
Hide resolved
AlexAndBear
force-pushed
the
tags-in-detail-panel
branch
from
21fc62b
to
9cf37c4
Compare
JammingBen
reviewed
Nov 9, 2023
packages/web-app-files/src/components/SideBar/Details/TagsSelect.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/SideBar/Details/TagsSelect.vue
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
JammingBen
approved these changes
Nov 9, 2023
12 tasks
AlexAndBear
added a commit
that referenced
this pull request
Dec 13, 2023
* MVP * removed unused composable * refactored to single component * renamed component, adjusted tests * fix import * Close sidebar on tag search * React on code review * Fix is router link in public page context * Fix unit tests * Fix unit tests * Fix link color * Fix e2e via timeout * Remove useless styling * Add changelog item * Fix e2e correctly --------- Co-authored-by: Jan Ackermann <jan.alexander.ackermann@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
moving tags panel to detail view
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: